Support has_many through associations with composite query_constraints #47452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given an association like: ```ruby BlogPost.has_many :blog_post_tags, query_constraints: [:blog_id, :blog_post_id] BlogPost.has_many :tags, through: :blog_post_tags ``` The `tags` association records can be queried and the resulting JOIN query will include both `blog_id` and `blog_post_id` in the ON clause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
has_many :items, through: :associationassociations defined with compositequery_constraintsThe change is similar to other ones. Since
reflection.join_primary_keyandreflection.join_foreign_keycan both be Arrayshttps://github.com/rails/rails/blob/4085395f41f8c9c712f39ea6bec64ae6161bfbc9/activerecord/lib/active_record/reflection.rb#L512-L515
https://github.com/rails/rails/blob/4085395f41f8c9c712f39ea6bec64ae6161bfbc9/activerecord/lib/active_record/reflection.rb#L496-L499
next_chain_scopeshould be ready to process them as arrays.Then we iterate over pairis of primary & foreign keys, building
Equalityarel nodes and joining them withANDif we have more than oneeqcondition.For tests
Shardedmodels were extended with theTagmodels that is associated withBlogPostthroughblog_posts_tagsjoining table